Possible leak in RefreshContainer where it doesn't stop a "Forever" composition animation

[Youssef1313]

Describe the bug

microsoft-ui-xaml/controls/dev/PullToRefresh/RefreshVisualizer/RefreshVisualizer.cpp

Lines 422 to 444 in 2a60e27

	void RefreshVisualizer::ExecuteExecutingRotationAnimation()
	{
	PTR_TRACE_INFO(nullptr, TRACE_MSG_METH, METH_NAME, this);
	if (m_content)
	{
	const winrt::Visual contentVisual = winrt::ElementCompositionPreview::GetElementVisual(m_content.get());
	if (!m_compositor)
	{
	m_compositor.set(contentVisual.Compositor());
	}
	const winrt::ScalarKeyFrameAnimation contentExecutionRotationAnimation = m_compositor.get().CreateScalarKeyFrameAnimation();
	contentExecutionRotationAnimation.InsertKeyFrame(0.0f, m_startingRotationAngle, m_compositor.get().CreateLinearEasingFunction());
	contentExecutionRotationAnimation.InsertKeyFrame(1.0f, m_startingRotationAngle + (float)(2.0f * M_PI), m_compositor.get().CreateLinearEasingFunction());
	contentExecutionRotationAnimation.Duration(500ms);
	contentExecutionRotationAnimation.IterationBehavior(winrt::AnimationIterationBehavior::Forever);
	const winrt::Size contentSize = m_content.get().RenderSize();
	contentVisual.CenterPoint({ (float)(contentSize.Height / 2), (float)(contentSize.Width / 2), 0.0f });
	contentVisual.StartAnimation(L"RotationAngle", contentExecutionRotationAnimation);
	}
	}

This animation apparently never stops?

So, if many RefreshContainers are repeatedly added to visual tree, goes into interacting state, then removed from visual tree, those animations are likely to get stuck?

This shouldn't be a problem for a single RefreshContainer as the next interaction will cause another StartAnimation("RotationAngle", ..) which should stop the previous one.

Steps to reproduce the bug

Expected behavior

No response

Screenshots

No response

NuGet package version

None

Windows version

No response

Additional context

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

• RefreshContainer doesn't work with ScrollView (#8815), similarity score: 0.70

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[codendone]

Do you see an issue in the running app, or are you just noticing some suspect code?

[Youssef1313]

Just noticed suspicious code. The only way this can start causing issues is repeated interaction with different RefreshContainers. Each RefreshContainer will keep one animation running unnecessarily, if I understand correctly.