Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node2Vec sklearn-like interface #958

Closed
wants to merge 9 commits into from

Conversation

dokato
Copy link
Contributor

@dokato dokato commented Jun 22, 2022

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

Implements enhancement mentioned in #566.

What does this implement/fix? Briefly explain your changes.

Node2Vec sklearn-like interface to be consistent with other embedding methods that support this syntax.

Any other comments?

PTAL @daxpryce . I wasn't sure about backward compatibility here, in particular is someone still wants to use a function, they need to change:

from graspologic.embed import node2vec_embed as node2vec

to

from graspologic.pipeline.embed import node2vec_embed as node2vec

@ghost
Copy link

ghost commented Jun 22, 2022

CLA assistant check
All CLA requirements met.

@dokato dokato changed the title Node2Vec sklearn like interface Node2Vec sklearn-like interface Jun 22, 2022
@daxpryce
Copy link
Contributor

@Nyecarr can you take a look at this and review?

@daxpryce daxpryce requested a review from nicaurvi August 19, 2022 17:40
@bdpedigo bdpedigo closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants