New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sparse support to multigraph LCC functions #804
Conversation
❌ Deploy Preview for graspologic failed. 🔨 Explore the source changes: ab14d8b 🔍 Inspect the deploy log: https://app.netlify.com/sites/graspologic/deploys/612518dd0f7f6a000820c040 |
@nyecarr you mentioned sparse omni the other day, I think fixing this will be necessary as part of that workflow |
looks like theres some formatting issues but the rest looks fine to me. |
formatting issues are probably because of isort |
@daxpryce it looks like the functions I was in the process of adding sparse support in this PR when I came across this - I wonder whether you all have any use for these things working on networkx or not? If not, we could just take out of our contract with the user for now? |
note that I think y'all care about this functionality (which I believe you reimplemented here https://github.com/microsoft/graspologic/blob/e5d896d3798aca526d592d4925c7f8be27e7b622/graspologic/pipeline/embed/omnibus_embedding.py#L162), not that I am necessarily advocating for these util functions to support networkx |
decision from talk on 12/14: just make this accept |
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Any other comments?