Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly1 #1062

Closed
wants to merge 3 commits into from
Closed

Anomaly1 #1062

wants to merge 3 commits into from

Conversation

gupta3a6
Copy link

  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

bdpedigo and others added 3 commits September 29, 2023 11:38
* Added Python 3.11 (graspologic-org#1039)

* add python 3.11

* fix numba dep warning

* add release note entry (graspologic-org#1040)

* Updated heatmap (graspologic-org#750)

* test pytest ini

* add binary_heatmap, updates to tutorial notebook

* test plotting

* re-add pytest.ini

* Update plot.py

Fix a few bugs

* add new tests

* Update setup.cfg

* remove binary_heatmap

* mpl version req back to normal

* remove binary_heatmap import

* black

* formatting fix

---------

Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>

* Fixed bugs in type specifications from Numpy 1.25 release (graspologic-org#1047)

* attempted fix for matrix type erroring

* fix spec of csr_array

* add a random seed

* remove isspmatrix

* fix a type check

* black

* Added option for more efficient graph matching matrix operations (graspologic-org#1046)

* more efficient graph matching matrix operations

* fix formatting

* remove an unused import (unrelated)

* expose fast kwarg to user, docs

* run black formatter

* add typehint

* fix mypy

---------

Co-authored-by: bkj <ben@jataware.com>
Co-authored-by: bdpedigo <benjamindpedigo@gmail.com>

* Added an `ax` argument for `screeplot`

* Add ax argument to screeplot (now returns None)

* add a return value for screeplot()

* Refactored for best practices

* Fixed Matplotlib 3.8 compatibility issues (graspologic-org#1049)

* specify angle as kwarg

* try removing some maybe unnecessary code?

* fight with mypy

* black

* fix sorts

* try switch to explain

* fix intersphinx

* other instances of wrong tutorial intersphinx

* 3.3.0 release prep (graspologic-org#1050)

* add release notes

* bump version

---------

Co-authored-by: Alex Loftus <alexloftus2004@gmail.com>
Co-authored-by: Ben Johnson <bkj.322@gmail.com>
Co-authored-by: bkj <ben@jataware.com>
Co-authored-by: Prajwal Agrawal <61898798+kidkoder432@users.noreply.github.com>
@j1c
Copy link
Collaborator

j1c commented Apr 29, 2024

@gupta3a6 I appreciate the PR but it seems like you are either working in really old branch or copied/pasted old code. It would be great in the future if you make PRs that follow our contributing guidelines.

@j1c j1c closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants