Removed references to IDAD in utils.py #1017
Conversation
main into dev pre 2.0.1
I added to line 35. I assumed the asterisk on 3.3 meant all versions of 3.3 ex (3.3.1, 3.3.2) are all excluded from the matplotlib. Is this correct?
Removed outdated Zenodo DOI from README.md
…aspologic-org#1002) * Fix seaborn syntax * fixed padding of a similarity amtrix for graph matching * fixing mypy complaint from _adj_pad * use naive padding for similarity * add a test * Revert "Fix seaborn syntax" This reverts commit fd38e05. * try to fix ipython error in doc generation * just make sure the original S had the right shape * run black * fix tests Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
* Editing contributing guidelines My edits were based on my experience with getting set up on GitHub. I added some minor changes of things I wish I had read while I was trying to set up my account. * fix typo Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
…g#1016) * hard capped networkx version to avoid incompatability * set networkx to <= 3.0 * Update setup.cfg Co-authored-by: alyakin314 <antonalyakin@Antons-MacBook-Pro-4.local> Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
|
@microsoft-github-policy-service agree [company="Johns Hopkins"] |
|
@microsoft-github-policy-service agree |
|
tests are still not passing |
|
I removed the tests, but I did it on dev. When I did the pull request for the deprecation errors, I accidentally pulled the changes to the test as well. I am unsure what to do about it about it applying. |
|
can you just make those changes again on this branch? im not sure what you are asking |
|
I made the changes, and it is the same test that is not passing for both pull requests. I think it is an issue with building documentation because when I run i-sort or black those tests pass but sphinx fails. It says it is an issue with "no python3 in kernal" and it is referencing a jupyter notebook. I couldn't find the juypter notebook in graspologic so I was pretty much lost as to how to trouble shoot from there. |
|
same comment as on the other PR - it looks like you need to rerun code formatting; make sure you are using the most recent version of |
* Editing contributing guidelines My edits were based on my experience with getting set up on GitHub. I added some minor changes of things I wish I had read while I was trying to set up my account. * fix typo * Resolving two deprecation warnings * Removing IDAD tests * Correcting some deprecation errors * Correcting more deprecation warnings * Revert "Removing IDAD tests" Moving commit to the correct location This reverts commit 00a2e76. * Correcting formatting errors: --------- Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com> Co-authored-by: hugwuoke <test@w3schools.com>
bdpedigo
changed the title
I caught a minor typo. Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
Reference Issues/PRs
Fixes #970