Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scipy deprecations causing importerrors in gensim #1059

Closed
j1c opened this issue Apr 16, 2024 · 4 comments
Closed

[BUG] Scipy deprecations causing importerrors in gensim #1059

j1c opened this issue Apr 16, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@j1c
Copy link
Collaborator

j1c commented Apr 16, 2024

Expected Behavior

scipy function triu used in gensim was deprecated in scipy==1.13.0. Limit scipy version

Example Code

import graspologic

Full Traceback

ImportError: cannot import name 'triu' from 'scipy.linalg'

Your Environment

  • Python version:
  • graspologic version:

Additional Details

Any other contextual information you might feel is important.

@j1c j1c added the bug Something isn't working label Apr 16, 2024
@j1c j1c changed the title [BUG] [BUG] Scipy deprecations causing importerrors in gensim Apr 16, 2024
@bdpedigo
Copy link
Collaborator

i noticed piskvorky/gensim#3524 - if they get a fix out soon, would be nice to use that instead of banning future scipy releases

@j1c
Copy link
Collaborator Author

j1c commented Apr 19, 2024

i noticed piskvorky/gensim#3524 - if they get a fix out soon, would be nice to use that instead of banning future scipy releases

Neat. This will probably mean we have to set a minimum to gensim instead then.

@bdpedigo
Copy link
Collaborator

agreed. thinking about it more, if you want to ban scipy 1.13 in the meantime like in your PR, i have no problem with that. who knows how long they will take to get a fix out.

@bdpedigo
Copy link
Collaborator

covered in #1067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants