Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose removing I-DAD as a laplacian #970

Closed
bdpedigo opened this issue Jul 6, 2022 · 1 comment
Closed

Propose removing I-DAD as a laplacian #970

bdpedigo opened this issue Jul 6, 2022 · 1 comment
Labels
discussion graspologic team discussion enhancement New feature or request

Comments

@bdpedigo
Copy link
Collaborator

bdpedigo commented Jul 6, 2022

related to #938

I propose that we don't need the I - DAD as an accepted laplacian, because:

pros:

  • our library always does SVD using top singular values, when using I - DAD one should be looking at the smallest in magnitude eigenvalues instead
  • we dont know of a paper that has a good definition of laplacian in the directed case for the I - version, though I'm guessing it'd be the same
  • reduce code footprint!

cons:

  • have to deprecate something

cc: @ebridge2
@bdpedigo bdpedigo added enhancement New feature or request discussion graspologic team discussion labels Jul 6, 2022
@bdpedigo
Copy link
Collaborator Author

remove all functionality related to I-DAD https://github.com/microsoft/graspologic/blob/dev/graspologic/utils/utils.py#L373

@hugwuoke hugwuoke mentioned this issue Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion graspologic team discussion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed references to IDAD in utils.py hugwuoke/graspologic
1 participant
@bdpedigo