Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration File ComboBox CTA #2739

Closed
TWhiteDesigns opened this issue Apr 24, 2024 · 0 comments · Fixed by #2859
Closed

Configuration File ComboBox CTA #2739

TWhiteDesigns opened this issue Apr 24, 2024 · 0 comments · Fixed by #2859
Assignees
@AmelBawa-msft
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-DSC Related to WinGet DSC configuration in machine config flow Craft-Red Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release Type-Craftsmanship Pertains to craftsmanship review feedback
Milestone
Dev Home v0.14

Comments

@TWhiteDesigns
Copy link

Dev Home version

0.1301.473.0

Windows build number

10.0.22631.3447

Other software

No response

Steps to reproduce the bug

Machine Configuration > Configuration File > Load yaml or repository file > See Accent CTA at bottom

Expected result

A better/more appropriate button type needs to be explored over the current combo box solution.
image

Actual result

Combo box button has 'setup as admin' as the default and 'setup as non admin as the secondary option, but when selecting the secondary option the action immediately executes. We anticipate this could lead to confidence desat and/or confusion

Included System Information

No response

Included Extensions Information

No response
@TWhiteDesigns TWhiteDesigns added the Issue-Bug Something isn't working or needs investigation label Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Apr 24, 2024
@TWhiteDesigns TWhiteDesigns added Craft-Red and removed Needs-Triage New issue that the core contributors need to triage labels Apr 24, 2024
@krschau krschau added Area-Machine-Config Related to the machine configuration feature Needs-Triage New issue that the core contributors need to triage Type-Craftsmanship Pertains to craftsmanship review feedback labels Apr 25, 2024
@kanismohammed kanismohammed added Area-Machine-Config-DSC Related to WinGet DSC configuration in machine config flow Priority-1 and removed Needs-Triage New issue that the core contributors need to triage labels Apr 29, 2024
@krschau krschau added this to the Dev Home v0.14 milestone Apr 29, 2024
@AmelBawa-msft AmelBawa-msft mentioned this issue May 10, 2024
Merged
3 tasks
@krschau krschau added the In-PR This issue has a related PR label May 10, 2024
@krschau krschau added Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release and removed In-PR This issue has a related PR labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmelBawa-msft AmelBawa-msft

Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-DSC Related to WinGet DSC configuration in machine config flow Craft-Red Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release Type-Craftsmanship Pertains to craftsmanship review feedback
Projects
None yet
Milestone
Dev Home v0.14
Development

Successfully merging a pull request may close this issue.

Replace toggle split button with two separate buttons in DSC page microsoft/devhome
4 participants
@krschau @kanismohammed @AmelBawa-msft @TWhiteDesigns