Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.78.0 of VSCode imposes max-height of CodeTour step window #285

Open
kazemicode opened this issue May 9, 2023 · 0 comments
Open

v1.78.0 of VSCode imposes max-height of CodeTour step window #285

kazemicode opened this issue May 9, 2023 · 0 comments

Comments

@kazemicode
Copy link

kazemicode commented May 9, 2023

VSCode v1.78.0, specifically, this PR, imposes a strict max-height for the UI component that CodeTour steps are displayed in. For anyone who uses CodeTour to embed images/video, this means that any media that surpasses this max-height cannot be seen in the frame all at once. I've proposed a VSCode feature request to expose functionality via the VSCode API to set the max-height rather than having an imposed max-height. At this time, it's unclear what the default behavior will be. If the default behavior goes back to dynamically adjusting the height of the UI component with the length of the content, no changes are warranted on the CodeTour side. If, however, the default behavior stays as it is now (a default max-height), we will need to specify a larger max-height value for CodeTour windows to display media in a non-cumbersome way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant