Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major change published as minor if major disallowment is present in package. Expected or bug? #932

Open
kevin-deyoungster opened this issue Dec 6, 2023 · 1 comment

Comments

@kevin-deyoungster
Copy link

Had a case where there was a major change file, but the package.json still had the disallowment

"disallowedChangeTypes": [
      "major"
]

I expected publish to fail, but from pipeline logs, we see that the major change got published as a minor. Is this expected behavior?

@ecraig12345
Copy link
Member

No, that's not expected--this might not be a case we've specifically thought about or handled, but I'd expect it to either fail when validating the change file, or successfully publish a major bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants