Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of group "exclude" options #916

Open
ecraig12345 opened this issue Sep 1, 2023 · 0 comments
Open

Fix behavior of group "exclude" options #916

ecraig12345 opened this issue Sep 1, 2023 · 0 comments
Labels
breaking change bug Something isn't working

Comments

@ecraig12345
Copy link
Member

Currently the exclude option for ChangelogGroupOptions and VersionGroupOptions (and isPathIncluded internally) expects negated patterns: e.g. if you want to exclude packages/foo, you must specify exclude as !packages/foo.

This is a counterintuitive design which does not match other tools, and should be updated in a major version to remove the negation requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant