Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-publish step to check validity of git auth #776

Open
ecraig12345 opened this issue Sep 16, 2022 · 0 comments
Open

Add pre-publish step to check validity of git auth #776

ecraig12345 opened this issue Sep 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Sep 16, 2022

The publish flow for beachball is currently as follows:

  1. bump packages locally
  2. publish to npm
  3. push to git

Currently when publishing packages, if the git auth is invalid (due to an expired token, incorrect URL, or other issue), this will result in the repo being out of sync with the published versions.

Therefore, it would be good to add a step prior to npm publish to check the validity of the github auth. I'm not sure what the best command would be to do this, since it appears that git fetch (which is run prior to publishing) succeeds for public repos even with an expired token.

@ecraig12345 ecraig12345 changed the title Add pre-publish step to check validity of github auth Add pre-publish step to check validity of git auth Sep 16, 2022
@ecraig12345 ecraig12345 added the enhancement New feature or request label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant