Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change command fetches twice #565

Open
ecraig12345 opened this issue Jul 28, 2021 · 0 comments · May be fixed by #569
Open

Change command fetches twice #565

ecraig12345 opened this issue Jul 28, 2021 · 0 comments · May be fixed by #569
Labels
bug Something isn't working

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Jul 28, 2021 •
edited

The change command runs git fetch at least twice. Example from the beachball repo:

$ yarn change
yarn run v1.22.10
$ node ./lib/cli.js change
Checking for changes against "origin/master"
fetching latest from remotes "origin/master"
Found changes in the following packages: 
  beachball
fetching latest from remotes "origin/master"

Please describe the changes for: beachball

Ideally it should only fetch once.
@ecraig12345 ecraig12345 added the bug Something isn't working label Jul 28, 2021
@ecraig12345 ecraig12345 changed the title Change command fetches 3 times Change command fetches 2 times Jul 30, 2021
@ecraig12345 ecraig12345 changed the title Change command fetches 2 times Change command fetches twice Jul 30, 2021
@ecraig12345 ecraig12345 linked a pull request Jul 30, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add caching for list of changed packages microsoft/beachball
1 participant
@ecraig12345