Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the purpose of setting a message for setResult(TaskResult.Succeeded, "Success"); calls? #940

Closed
Ethan-Arrowood opened this issue May 22, 2023 · 4 comments
Closed

What is the purpose of setting a message for setResult(TaskResult.Succeeded, "Success"); calls? #940

Ethan-Arrowood opened this issue May 22, 2023 · 4 comments
Assignees
@ivanduplenskikh
Labels
Area: TaskLib question

Comments

@Ethan-Arrowood
Copy link

Trying to better understand the setResult api. Based on the docs, I'm wondering what is the purpose of the second argument, message, when TaskResult.Succeeded is used? Should it be optional for that enum?
@ivanduplenskikh ivanduplenskikh self-assigned this May 23, 2023
ivanduplenskikh added a commit that referenced this issue May 23, 2023
@ivanduplenskikh
#940
eec4428 
Added overload signature.
When the result argument is TaskResult.Succeeded so the message can be optional
@ivanduplenskikh ivanduplenskikh mentioned this issue May 23, 2023
Merged
@ivanduplenskikh
Copy link
Contributor

ivanduplenskikh commented May 24, 2023 •
edited

Hi @Ethan-Arrowood, it's a good remark.
I made a new PR with proper overloads for function.

@Ethan-Arrowood
Copy link
Author

Could you take a look at #929 too? I opened this one for a similar thing

ivanduplenskikh added a commit that referenced this issue Jul 6, 2023
@ivanduplenskikh
#940 (#941)
ff62c9b 
Added overload signature.
When the result argument is TaskResult.Succeeded so the message can be optional
@ivanduplenskikh
Copy link
Contributor

@Ethan-Arrowood, I'm closing this issue for now so #941 has been merged.
I left a review comment in #929.

@Ethan-Arrowood
Copy link
Author

I don't see the review comment on #929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanduplenskikh ivanduplenskikh

Labels
Area: TaskLib question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ethan-Arrowood @ivanduplenskikh