Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.Net][Issue]: AutogenDotnetInteractive doesn't restore dotnet-interactive service when system language is Chinese #2660

Closed
feynmanloo opened this issue May 11, 2024 · 10 comments · Fixed by #2676
Labels
bug Something isn't working

Comments

@feynmanloo
Copy link

Describe the issue

image
image

Steps to reproduce

No response

Screenshots and logs

No response

Additional Information

No response

@LittleLittleCloud
Copy link
Collaborator

I haven’t tested dotnet interactive with asp net yet, would you mind sharing the code somewhere and I can debug into it

from the log the error is caused because dotnet interactive is not restored correctly. Note that the autogen.dotnetinteractive always try installing a specific version of dotnet interactive even though it’s installed globally. You can cd to work directory and see if you can open dotnet interactive cli there

@feynmanloo
Copy link
Author

I haven’t tested dotnet interactive with asp net yet, would you mind sharing the code somewhere and I can debug into it

from the log the error is caused because dotnet interactive is not restored correctly. Note that the autogen.dotnetinteractive always try installing a specific version of dotnet interactive even though it’s installed globally. You can cd to work directory and see if you can open dotnet interactive cli there

@LittleLittleCloud thx a lot !
https://github.com/feynmanloo/AutogenDotnetInteractiveDemo

@LittleLittleCloud
Copy link
Collaborator

@feynmanloo Your code works on my local environment. May I ask which dotnet SDK do you have on your environment?

Here's my SDKs

dotnet --list-sdks
7.0.408 [C:\Program Files\dotnet\sdk]
8.0.204 [C:\Program Files\dotnet\sdk]

@feynmanloo
Copy link
Author

@feynmanloo Your code works on my local environment. May I ask which dotnet SDK do you have on your environment?

Here's my SDKs

dotnet --list-sdks
7.0.408 [C:\Program Files\dotnet\sdk]
8.0.204 [C:\Program Files\dotnet\sdk]

@LittleLittleCloud
dotnet --list-sdks
6.0.420 [C:\Program Files\dotnet\sdk]
7.0.408 [C:\Program Files\dotnet\sdk]
8.0.204 [C:\Program Files\dotnet\sdk]

@LittleLittleCloud
Copy link
Collaborator

@feynmanloo I think I figure it out. The InteractiveService restores dotnet-interactive when it receives an CommandLineInvocationException with error message that contains cannot find a tool in the manifest file that has a command named 'dotnet-interactive'. But since your system language is Chinese, so the error message will also be in Chinese and it doesn't contain that specific message piece.

We will push a fix for this issue in 0.0.14. To unblock yourself, you can mannually restore the dotnet interactive by calling RestoreDotnetInteractive. This method is private though so you might need to use reflection to call that method. See this link on how to do that

@LittleLittleCloud LittleLittleCloud changed the title [Issue]: AutogenDotnetInteractive Can't Work [Issue]: AutogenDotnetInteractive doesn't restore dotnet-interactive service when system language is Chinese May 13, 2024
@LittleLittleCloud LittleLittleCloud changed the title [Issue]: AutogenDotnetInteractive doesn't restore dotnet-interactive service when system language is Chinese [.Net][Issue]: AutogenDotnetInteractive doesn't restore dotnet-interactive service when system language is Chinese May 13, 2024
@LittleLittleCloud LittleLittleCloud added this to the AutoGen.Net 0.0.14 milestone May 13, 2024
@feynmanloo
Copy link
Author

feynmanloo commented May 14, 2024

How soon is this release expected? @LittleLittleCloud

@LittleLittleCloud
Copy link
Collaborator

@feynmanloo Might be 2-3 weeks, depends on the progress of other working items.

You can also consume the nightly build as well, which will be available once #2676 get merged into main

@LittleLittleCloud LittleLittleCloud added the bug Something isn't working label May 14, 2024
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
* update

* fix 2660

* remove unnecessary feed
@feynmanloo
Copy link
Author

@feynmanloo Might be 2-3 weeks, depends on the progress of other working items.

You can also consume the nightly build as well, which will be available once #2676 get merged into main

@LittleLittleCloud
can't find the newly nightly build package from myget, and i find this ci error:
https://github.com/microsoft/autogen/actions/runs/9073421528/job/24934786609

@LittleLittleCloud
Copy link
Collaborator

Looks like the API key is expired, I will update the key and rerun the workflow

@LittleLittleCloud
Copy link
Collaborator

@feynmanloo Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants