Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Windows Community Toolkit library instead of custom code #348

Open
wldevries opened this issue Oct 4, 2020 · 1 comment
Open

Use Windows Community Toolkit library instead of custom code #348

wldevries opened this issue Oct 4, 2020 · 1 comment

Comments

@wldevries
Copy link

It would be helpful for new users to be pointed to the Windows Community Toolkit for extra functionality. The ExpressionBuilder is best used as a library instead of copying the code from this sample. Similarly a user is better off using a library for loading image brushes instead of the half native implementation that is hard to copy to your own solution.

Use functionality from the Windows Community Toolkit instead of the custom implementations for

  • ExpressionBuilder -> Microsoft.Toolkit.Uwp.UI.Animations.Expressions
  • SamplesNative and image loading -> Microsoft.Toolkit.Uwp.UI.Media.Helpers.SurfaceLoader

Issue Type

[ ] Bug Report
[x] Feature Request
[ ] Sample request
[ ] Documentation issue or request
[ ] Other – Please describe:

UserVoice link

Current Behavior

Expected Behavior

Steps to Reproduce (for bugs)

Your Environment

  • SDK #:
  • Operating System build # :
  • Visual Studio Version # :
@hawkerm
Copy link

hawkerm commented Mar 12, 2021

I actually think the ExpressionBuilder code here is what's in the Toolkit. I don't know the history, but it'd certainly make sense to try and simplify the sample repo by using the Toolkit as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants