Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and Targets to build in VS 2019 #350

Closed
wants to merge 1 commit into from

Conversation

hawkerm
Copy link

@hawkerm hawkerm commented Mar 12, 2021

Pull Request Type

  • Bugfix
  • New Sample
  • Other - Please describe:

Issue

Fixes #343

Proposed Changes

  • Update VS Tooling, UWP, and Win2D dependencies
  • Move Min Target to 16299 to get newer build chain (everything before then is out of mainstream support, and that least LTSC branch is beyond it.) Windows 10 Version History

Was able to build and run fine 馃帀

image

Tried on 16.8.3 and 16.9.1

Move Min Target to 16299 to get newer build chain.
@ghost
Copy link

ghost commented Mar 12, 2021

CLA assistant check
All CLA requirements met.

@kevinguo305
Copy link
Contributor

Hey Michael,

Thanks so much for the PR. After running the project, we were still running into a Win2D issue, so we've gone ahead and updated the Win2D version as well as the platform toolset so that it works with VS2019 which should address the build issues (Commit link here). Please let us know if you're experiencing any issues still.

Note that we'll be moving this project over to the Windows App SDK, but we'll tag this commit so that people have easier reference to the UWP version.

@kevinguo305 kevinguo305 closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error in VS2019 and VS2019 preview
2 participants