Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how source codes (C#/XAML) are displayed #1535

Open
ghost1372 opened this issue May 8, 2024 · 4 comments
Open

Change how source codes (C#/XAML) are displayed #1535

ghost1372 opened this issue May 8, 2024 · 4 comments

Comments

@ghost1372
Copy link
Contributor

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

Currently displaying codes is too long and confusing.
Using Pivot/selector bar can shorten the code and make it easier to use.

this Currently design
image

I have used pivot for my app and it is as follows
Screenshot 2024-05-08 203240

@karkarl If approved, I can create a PR for this.

Screenshots

No response

Windows version

Insider Build (xxxxx), Windows 11 24H2 (26052), Windows 11 23H2 (22631), Windows 11 22H2 (22621), Windows 11 21H2 (22000), Windows 10 22H2 (19045), November 2021 Update/21H2 (19044), May 2021 Update/21H1 (19043), October 2020 Update/20H2 (19042), October 2018 Update/RS5 (17763)

Additional context

No response

@Jay-o-Way
Copy link
Contributor

I've learned that Pivot is deprecated, but SelectorBar is almost identical.

@niels9001
Copy link
Collaborator

@karkarl I think this makes sense? We do the same thing in the Windows Community Toolkit Gallery:

image

@karkarl
Copy link
Collaborator

karkarl commented May 16, 2024

@karkarl I think this makes sense? We do the same thing in the Windows Community Toolkit Gallery:

image

Let's do it! I like the idea of aligning design patterns with Community toolkit.

@ghost1372
Copy link
Contributor Author

ghost1372 commented May 17, 2024

@karkarl i used SwitchPresenter from communityToolkit.(I copied its codes directly in the repository)
i created a pr which is working fine.
#1540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤞 Committed
Development

No branches or pull requests

4 participants