Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check description of CommandBar please #1518

Closed
Jay-o-Way opened this issue Mar 31, 2024 · 3 comments · Fixed by #1529
Closed

Check description of CommandBar please #1518

Jay-o-Way opened this issue Mar 31, 2024 · 3 comments · Fixed by #1529
Labels
enhancement Expand an existing sample or add feature to app

Comments

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Mar 31, 2024 •
edited

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

App says

[...] When you need an app bar that contains only AppBarButton,AppBarToggleButton , and AppBarSeparator controls, use a CommandBar. If you need more complex content, such as images, progress bars, or text blocks, use an AppBar control."

MS Learn says

Important

You should use the AppBar only when you are upgrading a Universal Windows 8 app that uses the AppBar, and need to minimize changes. For new apps in Windows 10, we recommend using the CommandBar control instead.

https://learn.microsoft.com/uwp/api/windows.ui.xaml.controls.appbar?view=winrt-22621
@Jay-o-Way
Copy link
Contributor Author

Also, what's with "primary on the right and secondary on the left" ?

@karkarl
Copy link
Collaborator

karkarl commented Apr 11, 2024

@jwmsft Are you able to weigh in?

@karkarl karkarl added enhancement Expand an existing sample or add feature to app and removed needs-triage labels Apr 11, 2024
@jwmsft
Copy link
Member

jwmsft commented Apr 11, 2024

@Jay-o-Way, thanks for letting us know about this issue.
It looks like CommandBar still has the description from the original Windows 8 version of the control, and it wasn't updated for the design and behavior changes that happened in Windows 10. (If you're wondering how the app ever got the Windows 8 descriptions in the first place, the WinUI Gallery is an evolution of a sample that was originally written for the Windows 8 docs.)

@karkarl, the description should be updated to reflect the current documentation.

@Jay-o-Way Jay-o-Way mentioned this issue Apr 25, 2024
Merged
3 tasks
karkarl pushed a commit that referenced this issue May 15, 2024
@Jay-o-Way
Update CommandBar description (#1529)
16890a1 
## Description
Quick update to the description (copy from MS Learn)

## Motivation and Context
Text is outdated / does not apply.
fixes #1518

## Screenshots (if appropriate):

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/386ed581-60ff-4ff6-b2b7-3f83027d0b53)

## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Expand an existing sample or add feature to app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CommandBar description Jay-o-Way/WinUI-Gallery
3 participants
@karkarl @jwmsft @Jay-o-Way