Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VisualState margin at MinWidth #1502

Closed
Jay-o-Way opened this issue Mar 16, 2024 · 4 comments
Closed

UI: VisualState margin at MinWidth #1502

Jay-o-Way opened this issue Mar 16, 2024 · 4 comments
Assignees
@niels9001
Labels
app enhancement Requests for general app improvements bug Something isn't working

Comments

@Jay-o-Way
Copy link
Contributor

Which version of the app?

WinUI 3 Gallery

Description

When making the window as small as possible, there is too much margin next to the title and controls.

Screenshots

image

Windows version

No response

Additional context

No response
@Jay-o-Way Jay-o-Way added bug Something isn't working needs-triage labels Mar 16, 2024
@karkarl karkarl added app enhancement Requests for general app improvements and removed needs-triage labels Mar 21, 2024
@niels9001 niels9001 self-assigned this Mar 23, 2024
@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Apr 16, 2024 •
edited

@niels9001 is this maybe because the VisualState in PageHeader does not mix with the VisualState in ItemPage? Maybe it's better to use one padding at the right place.

@niels9001
Copy link
Collaborator

Hmm.. I thought we fixed this with the overhaul. Apparently not..

@Jay-o-Way Yeah that might make sense

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Apr 16, 2024 •
edited

Or, it's because

WinUI-Gallery/WinUIGallery/ItemPage.xaml

Line 55 in c3cf8db

<Setter Target="pageHeader.Padding" Value="16,48,16,0" />

does work, but

WinUI-Gallery/WinUIGallery/Controls/PageHeader.xaml

Line 21 in c3cf8db

<Grid x:Name="headerGrid" Padding="36,24,36,0">

remains.

Looks like Setter Target="pageHeader.Padding" doesn't work?

@Jay-o-Way Jay-o-Way changed the title UI placing/margin at MinWidth UI: VisualState margin at MinWidth May 9, 2024
@niels9001 niels9001 mentioned this issue May 16, 2024
Merged
karkarl pushed a commit that referenced this issue May 16, 2024
@niels9001
Fix pageheader spacing at smaller window widths (#1537)
aad46f5 
This PR fixes an incorrect padding being used when the window has a
small window width. The `PageHeader` control would not align correctly
with the page content.

Addressing: #1502

Before:

![image](https://github.com/microsoft/WinUI-Gallery/assets/9866362/57faee26-9a44-4454-bec7-92c98fc90595)



After:


![image](https://github.com/microsoft/WinUI-Gallery/assets/9866362/4836943e-0e1b-4626-ab19-687dbae7dd1d)
@Jay-o-Way
Copy link
Contributor Author

Fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niels9001 niels9001

Labels
app enhancement Requests for general app improvements bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karkarl @niels9001 @Jay-o-Way