Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openEuler in --online list #9438

Open
pkking opened this issue Jan 5, 2023 · 10 comments
Open

openEuler in --online list #9438

pkking opened this issue Jan 5, 2023 · 10 comments
Assignees
Labels
documentation request for documentation improvement feature

Comments

@pkking
Copy link

pkking commented Jan 5, 2023

Is your feature request related to a problem? Please describe.
We have submit a openEuler wsl appx and want to include it in wsl -l --online

Describe the solution you'd like
Want to see/install the openEuler WSL through wsl -l --online/wsl --install and in the wsl install guide docs, a download link is also provided.

Describe alternatives you've considered
NA

Additional context
NA

@pkking pkking added the feature label Jan 5, 2023
@craigloewen-msft craigloewen-msft self-assigned this Jan 5, 2023
@craigloewen-msft craigloewen-msft added the documentation request for documentation improvement label Jan 5, 2023
@craigloewen-msft
Copy link
Member

Hi @pkking I'd be happy to help.

Can you link me to the Store app that you would like to be on the --online list? Once you do that I'll open a PR to add it and link you to it so you can review.

Thanks!

@pkking
Copy link
Author

pkking commented Jan 14, 2023

Hi @pkking I'd be happy to help.

Can you link me to the Store app that you would like to be on the --online list? Once you do that I'll open a PR to add it and link you to it so you can review.

Thanks!

Thanks your reply, @craigloewen-msft , these are:

@craigloewen-msft
Copy link
Member

We are trying to keep the wsl --list --online command output as low as possible, is there one version that you'd want to specifically put in the list? Or is it possible to make a distro that's just called openEuler that just gives the latest version?

For more context the list right now does include multiple versions of some distros, this was based on existing usage, so they already had a significant amount of users on those versions.

@pkking
Copy link
Author

pkking commented Jan 18, 2023

@craigloewen-msft If one version must be choosed, it will be latest LTS version: openEuler 22.03
But after a newer LTS version published, maybe we need to replace this option :)

@craigloewen-msft
Copy link
Member

Ok that seems reasonable! I will create a PR for this on Monday. Thanks for filing this @pkking !

@craigloewen-msft
Copy link
Member

PR here:
#9522

@craigloewen-msft
Copy link
Member

@pkking can you take a look at the PR? there are some items in there that aren't needed that can reduce the WSL distro size.

@pkking
Copy link
Author

pkking commented Jan 29, 2023

@pkking can you take a look at the PR? there are some items in there that aren't needed that can reduce the WSL distro size.

@craigloewen-msft Hi, thanks for the PR, as we discuss before, maybe we should add openEuler 22.03, not 22.09

Also thanks the size catch, will try to fix it later, but i think this will not block the PR, right?
The PR LGTM now.

@pkking
Copy link
Author

pkking commented May 5, 2023

@craigloewen-msft we have pushed a new app releases and cut down the size, can you take a look for this ticket again?

@pkking
Copy link
Author

pkking commented Jul 4, 2023

图片
@craigloewen-msft Hi, the newest WSL already pruned these content, can you please rebase and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation request for documentation improvement feature
Projects
None yet
Development

No branches or pull requests

2 participants