Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging when recv_message can't parse an inbound message #5571

Open
achamayou opened this issue Aug 18, 2023 · 0 comments
Open

Add logging when recv_message can't parse an inbound message #5571

achamayou opened this issue Aug 18, 2023 · 0 comments
Labels

Comments

@achamayou
Copy link
Member

This is currently logged:

Exception in virtual void aft::Aftconsensus::LedgerEnclave::recv_message(const ccf::NodeId
&, const uint8_t *, size_t) [LedgerProxy = consensus::LedgerEnclave]

But the payload is encrypted, and so is safe to log while being potentially helpful in understanding how the traffic ends up there.

@achamayou achamayou added the TODO label Aug 18, 2023
@achamayou achamayou added this to the 4.x milestone Sep 8, 2023
@achamayou achamayou removed this from the 4.x milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant