Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JS runtime options to be set individually #5562

Open
eddyashton opened this issue Aug 17, 2023 · 3 comments
Open

Allow JS runtime options to be set individually #5562

eddyashton opened this issue Aug 17, 2023 · 3 comments
Labels

Comments

@eddyashton
Copy link
Member

We currently have a single proposal to set JS runtime options, and all options must be provided. I think it would be simpler if this took a partial object, and only updated the fields it was provided. On the C++ side, this would mean setting default values at struct construction time, so that we have sane defaults whether-or-not there is a governance-controlled value in the KV.

Motivation is from adding another option here (max_cached_interpreters), and realising how much code is involved in configuring that, even to restore it to a default.

@achamayou
Copy link
Member

@lynshi brought up the possibility of having patch-style actions when we discussed idempotent actions at first #2169 (reply in thread)

@eddyashton
Copy link
Member Author

For the current use case, we may just set it in a separate proposal. Not written above but I meant to:

There's also some duplication of default values. I think that could be minimised by pushing stuff through C++, materialising default values, and similar. It's all in my head, and unimportant, and I'm sure I won't forget it...

@achamayou
Copy link
Member

+1 for materialising default values in the KV, which I think can be done as a standalone change before adding a patch mechanism to governance (which may be of interest to applications too, in fact).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants