Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmetric4j license issue #1354

Closed
srdo opened this issue Apr 2, 2019 · 2 comments
Closed

gmetric4j license issue #1354

srdo opened this issue Apr 2, 2019 · 2 comments
Labels
registry: ganglia A Ganglia Registry related issue type: task A general task

Comments

@srdo
Copy link

srdo commented Apr 2, 2019

gmetric4j depends on org.acplt.remotetea:remotetea-oncrpc, which is under LGPL license.

The Ganglia integration uses gmetric4j, which is why Dropwizard Metrics removed support for Ganglia recently ganglia/gmetric4j#9.

I'm guessing this is also an issue for Micrometer.
@shakuzen
Copy link
Member

Thank you for bringing this to our attention. I'm not sure we have a good option other than to drop Ganglia support, then.

@shakuzen shakuzen added release notes Noteworthy change to call out in the release notes type: task A general task labels Apr 10, 2019
@shakuzen shakuzen added this to the 1.1.11 milestone Feb 7, 2020
@shakuzen shakuzen changed the title gmetric4j license issue Remove Ganglia support due to gmetric4j license issue Feb 7, 2020
@shakuzen shakuzen added the registry: ganglia A Ganglia Registry related issue label Feb 7, 2020
@shakuzen shakuzen changed the title Remove Ganglia support due to gmetric4j license issue gmetric4j license issue Feb 10, 2020
shakuzen added a commit that referenced this issue Feb 10, 2020
@shakuzen
Note ganglia registry's dependency's licensing
d580cb7 
See #1354
@shakuzen shakuzen mentioned this issue Feb 10, 2020
Closed
@shakuzen shakuzen removed the release notes Noteworthy change to call out in the release notes label Feb 10, 2020
@shakuzen
Copy link
Member

I have added a note to the micrometer-registry-ganglia module's README in d580cb7. I have also added the note to the documentation site with micrometer-metrics/micrometer-docs#118. I am not a lawyer, but I think it is up to users of micrometer-registry-ganglia to determine whether what is documented prevents them from using it or not based on their situation. As far as I can tell, our usage does not force the LGPL license on Micrometer. Popular libraries like Hibernate are LGPL licensed, and we provide optional integration with them as well without being LGPL licensed ourselves.

@shakuzen shakuzen removed this from the 1.1.11 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
registry: ganglia A Ganglia Registry related issue type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srdo @shakuzen