Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beauty punycode urls #106

Open
Kikobeats opened this issue May 7, 2018 · 1 comment
Open

Beauty punycode urls #106

Kikobeats opened this issue May 7, 2018 · 1 comment

Comments

@Kikobeats
Copy link
Member

Currently we can't beautify punicode urls, like https://xn--vi8hl0c.ws/

This could be done adding punycode or similar dependency:
https://github.com/sindresorhus/normalize-url/blob/master/index.js#L112

but it's a little heavy (https://bundlephobia.com/result?p=punycode@2.1.0) so I want investigate and found a workaround first

@Kikobeats
Copy link
Member Author

After investigate, using Tree shaking the size is like ~1.6kB, so that's okay.

Also, we can use it for all the text inside the card, not just the url.

Need to be implemented at nanoclamp first! microlinkhq/nanoclamp#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant