Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe an implementation bug in Dragonfly Plate Reverb #168

Open
Quotation opened this issue Feb 27, 2024 · 0 comments
Open

Maybe an implementation bug in Dragonfly Plate Reverb #168

Quotation opened this issue Feb 27, 2024 · 0 comments

Comments

@Quotation
Copy link

Hi there,

I found some potential issue in Dragonfly Plate Reverb source code. Is it a bug, or just some unused code?

In dragonfly-plate-reverb/DSP.cpp, DragonflyReverbDSP::run(), we set model to different value.

        if (algorithm == ALGORITHM_NREV) {
          model = &nrev;
        } else if (algorithm == ALGORITHM_NREV_B) {
          model = &nrevb;
        } 
        ...

Then call model->processreplace(). For nrev and nrevb, they both use FV3_(nrev)::processreplace(). NRevB::processloop2() is never called.
Should we call processloop2() here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant