Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.8: CLAP: Wrong rendering in Reaper #151

Open
koalastudio72 opened this issue Jan 1, 2023 · 8 comments
Open

3.2.8: CLAP: Wrong rendering in Reaper #151

koalastudio72 opened this issue Jan 1, 2023 · 8 comments

Comments

@koalastudio72
Copy link

Hi,
I have the issue that the CLAP-Version in 3.2.8 doesn't fit in the plugin window in Reaper 6.73 (WIN-Version).

Screenshot:
2023-01-01_15-28

Thank you.

@falkTX
Copy link
Contributor

falkTX commented Jan 1, 2023

what is your display scale factor? seems to be different than 100%

@koalastudio72
Copy link
Author

Thanks for the quick reply.

My scale factor: 125%
But the VST2/VST3 versions fit well with this scale factor.
When I switch to 100% all the text is unfortunately too small on a 15 inch laptop display. Any idea ?

@falkTX
Copy link
Contributor

falkTX commented Jan 1, 2023

Might be a bug in reaper since the other versions work correctly.
Do you have any other host installed that can also load clap in order to verify this? Bitwig or MultitrackStudio

@koalastudio72
Copy link
Author

Unfortunately not.
Certainly I can live with the other versions and wait until the CLAP-versions work correct in Reaper.
Nevertheless thank you for you support.

@biopsin
Copy link

biopsin commented Jan 3, 2023

Same thing happens for LV2 too

@falkTX
Copy link
Contributor

falkTX commented Jan 3, 2023

I think I know why, but no time to investigate it proper at the moment.

@trebmuh
Copy link
Contributor

trebmuh commented Jan 5, 2023

@pawelulita
Copy link

I can reproduce it on Linux with Reaper, but not with Bitwig. Applying this patch to DPF makes the plugin size correct in Reaper and doesn't affect it in Bitwig. However, I have no idea if this is just a hack that fixes the problem for this plugin, or if this is (part of) a proper fix for a bug in DPF.

diff --git a/distrho/src/DistrhoPluginCLAP.cpp b/distrho/src/DistrhoPluginCLAP.cpp
index 29a0316d..0ad05ccd 100644
--- a/distrho/src/DistrhoPluginCLAP.cpp
+++ b/distrho/src/DistrhoPluginCLAP.cpp
@@ -297,6 +297,9 @@ public:
        #ifdef DISTRHO_OS_MAC
         *width /= scaleFactor;
         *height /= scaleFactor;
+       #else
+        *width *= scaleFactor;
+        *height *= scaleFactor;
        #endif
 
         return true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants