Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keys to be returned? #5

Open
michaelhelmick opened this issue Aug 14, 2013 · 1 comment
Open

Default keys to be returned? #5

michaelhelmick opened this issue Aug 14, 2013 · 1 comment

Comments

@michaelhelmick
Copy link
Owner

So right now, lassie will always return the keys image, video and url

{
    'images': [],
    'url': 'http://somesitethatdoesnthaveanythingbutexists.com',
    'videos': []
}

Does anything think that if images or videos are empty before the time to return a response, that those keys should be popped out of the dict?

@yaph
Copy link
Contributor

yaph commented Sep 5, 2013

I'd keep them with sensible default values, so the applications that import lassie can do a simple if check instead of calling get and then checking if the value evaluates to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants