Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle wrong URL setting #20

Open
yaph opened this issue Jul 15, 2014 · 1 comment
Open

How to handle wrong URL setting #20

yaph opened this issue Jul 15, 2014 · 1 comment

Comments

@yaph
Copy link
Contributor

yaph commented Jul 15, 2014

I fetched the page http://bibviz.com/ using Lassie, the page has the following og:url setting
property="og:url" content="/". Lassie correctly returns the "incorrect" URL.

I wonder if cases like that should be handled by Lassie, i. e. being more forgiving of bad markup, or the calling code. A possibility to handle this in Lassie would be to check that the URL string starts with supported protocols, e. g. http://, https://, and ?.

@michaelhelmick
Copy link
Owner

If the content doesn't start with http(s), I think we can allow lassie to be more forgiving and just use the url that the user is requesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants