Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the status of GH Actions Checks #462

Open
williamluke4 opened this issue Feb 10, 2021 · 4 comments · May be fixed by #473
Open

Display the status of GH Actions Checks #462

williamluke4 opened this issue Feb 10, 2021 · 4 comments · May be fixed by #473
Assignees
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)

Comments

@williamluke4
Copy link

williamluke4 commented Feb 10, 2021

Example

image

  • Display GH Actions Status
  • Provide link to action details ☝️
@mhutchie
Copy link
Owner

mhutchie commented Feb 10, 2021

Hi @williamluke4,

Thanks for raising this feature request, this would definitely be great to have in Git Graph!

The only hesitation I have is that this is a vendor specific capability, which can only be used by the portion of the extensions users that use public GitHub repositories and GitHub actions. One of the biggest factors I use when prioritising the implementation of features is the number of users will get value from the feature, so anything vendor specific is generally lower on the list. Additionally, once I implement one vendor specific feature, almost certainly many others will follow for a variety of different vendors - leading to a lot of code sitting unused for every user (currently the extension is very lean).

The only exception I’ve currently made to this rule is for commit author avatars, as it is a broad capability available by most vendors, and it was fairly reasonable to support the most common vendors (so a large portion of users were able to use it). In saying that, avatars have been extremely painful to deal with in the long term.

I’ll see how much user interest there is for this feature. If enough users would value this feature, I’ll happily implement it.

FYI: I included the above vendor comments just to make people aware that it is something I have to consider (most users overlook it). As long as there’s enough users who indicate they will value a feature, I’ll implement it regardless of whether it's vendor neutral or vendor specific.

@mhutchie mhutchie added the nice to have A feature request that is nice to have (lower priority) label Feb 10, 2021
@keydepth
Copy link

keydepth commented Mar 6, 2021

Hello! @mhutchie and @williamluke4 ,

Every day I use Git Graph extention.
This is very confourtable git extention for my software developnment.
I'd like to upgrade for this issue.
Please assign to me this issue.

I'v checked vendor specific automation API.
GitHub Actions has workflow-jobs API, GitLab has Pipeline API and Jenkins has Build Status.

GitHub Actions has workflow-jobs API

GitLab Pipeline API

Jenkins Build Status API

I need pipeline status, so I'm going to develop column of GitLab Pipeline Status, like this below.

image

"success" is pipeline status and link to action details. Frontend is under conftruction..

We need GitLab Pipeline setting is in "Repository Settings"

There are Add / Edit / Remove settings.

image

This is detail of setting dialog.

image

@mhutchie mhutchie assigned keydepth and unassigned mhutchie Mar 6, 2021
@mhutchie
Copy link
Owner

mhutchie commented Mar 6, 2021

Hi @keydepth,

Thanks for your work so far, that’s definitely some great progress!

Once you get to a releasable solution, please raise a PR so I can try it out, review your implementation, and give feedback.

keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 6, 2021
@keydepth
Copy link

keydepth commented Mar 6, 2021

Hello! @mhutchie,

I've implemented Pipeline/Workflow status for GitLab/GitHub.
It's just preview commit.
I'll change this feature name "Pipeline Status" to "CI/CD Status",
because "Pipeline" is only in the GitLab.

keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 7, 2021
@keydepth keydepth linked a pull request Mar 7, 2021 that will close this issue
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 8, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 10, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 10, 2021
@mhutchie mhutchie linked a pull request Mar 14, 2021 that will close this issue
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 14, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 15, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 15, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 15, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Mar 28, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue Apr 16, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 22, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 23, 2021
keydepth added a commit to keydepth/vscode-git-graph that referenced this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants