Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple new lines seem to add an empty row #94

Open
mhkeller opened this issue Jun 19, 2020 · 3 comments
Open

Multiple new lines seem to add an empty row #94

mhkeller opened this issue Jun 19, 2020 · 3 comments

Comments

@mhkeller
Copy link
Owner

mhkeller commented Jun 19, 2020

This is the same behavior as d3-dsv. Seems like another option would be to call .trim() before reading and expose an option to disable that if necessary. Indian ocean already strips out the BOM character so could make sense. i dont really see how loading in empty lines would ever be meaningful.

@aubergene
Copy link
Contributor

I wouldn't change the API of d3-dsv, though it seems strange, also not something that I've encountered

@mhkeller
Copy link
Owner Author

It wouldn't be an api change just adding a trim here. Something like this: #95

@mhkeller
Copy link
Owner Author

This is mostly done on the trim branch. Since it's a breaking change, I'm going to wait until this is done #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants