Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbs installer encoding issue + different error messages in and out of IDE #285

Open
sbwiecko opened this issue Sep 29, 2022 · 0 comments
Open

Comments

@sbwiecko
Copy link

fbs apparently doesn't like my French accent, as fbs installer stops throwing the following

Bad text encoding: Installer.nsi:13
Error in script "Installer.nsi" on line 13 -- aborting creation process

When I look into the Installer.nsi file at line 13, I found that the "é" on my name is not good.
VIAddVersionKey "LegalCopyright" "(C) Sébastien"

  1. Is there anything I can do to force another encoding in fbs? Otherwise I just start another project with another name.
  2. Believe me or not, but the error message while using fbs installer is totally different in the context of an IDE, e.g., in the terminal insise VSCode, compared to the same terminal but outside of the IDE. Inside the IDE:
❯ fbs installer
Traceback (most recent call last):
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\Scripts\fbs.exe\__main__.py", line 7, in <module>
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\__main__.py", line 17, in _main
    fbs.cmdline.main()
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\cmdline.py", line 32, in main
    fn(*args)
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\builtin_commands\__init__.py", line 220, in installer
    create_installer_windows()
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\installer\windows.py", line 13, in create_installer_windows
    raise FileNotFoundError(
FileNotFoundError: fbs could not find executable 'makensis'. Please install NSIS and add its installation directory to your PATH environment variable.

And outside the IDE, from the exact same directory and environment:

❯ fbs installer
Bad text encoding: Installer.nsi:13
Error in script "Installer.nsi" on line 13 -- aborting creation process
Traceback (most recent call last):
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\Scripts\fbs.exe\__main__.py", line 7, in <module>
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\__main__.py", line 17, in _main
    fbs.cmdline.main()
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\cmdline.py", line 32, in main
    fn(*args)
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\builtin_commands\__init__.py", line 220, in installer
    create_installer_windows()
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\site-packages\fbs\installer\windows.py", line 8, in create_installer_windows
    check_call(
  File "C:\Users\Sébastien\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['makensis', 'Installer.nsi']' returned non-zero exit status 1.

Microsoft Windows 10.0.22622
Python 3.10.7
fbs 1.1.4
pyinstaller 5.4.1
PySide6 6.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant