Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A hash sign in a property value results in incorrect .davmail.properties being saved #326

Open
hategan opened this issue Jan 9, 2024 · 1 comment
Open

A hash sign in a property value results in incorrect .davmail.properties being saved #326

hategan opened this issue Jan 9, 2024 · 1 comment

Comments

@hategan
Copy link

hategan commented Jan 9, 2024

The following line in .davmail.properties causes problems:

davmail.trayBackgroundColor=#c49fe2

Whenever Settings.save() is invoked, the value gets duplicated (e.g., davmail.trayBackgroundColor=#c49fe2#c49fe2). This appears to be caused by Settings.convertLine(), which considers hash signs in property values to introduce a comment. However, according to https://docs.oracle.com/cd/E23095_01/Platform.93/ATGProgGuide/html/s0204propertiesfileformat01.html, comments are only introduced by a hash sign in the beginning of a line.
mguessan added a commit that referenced this issue Jan 13, 2024
@mguessan
Fix settings implementation, # are allowed in values, see #326
078454e 
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@3513 3d1905a2-6b24-0410-a738-b14d5a86fcbd
@mguessan
Copy link
Owner

Correct, implementation was wrong and did not allow hash in comments.
Fix available in trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hategan @mguessan