New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Make (middleware) config case-agnostic #893
Comments
Good issue. Might be better indeed, since environment parameters are not case sensitive either. |
I was thinking that maybe we should convert all config from 'camelCase' to 'snake_case', before making them case-insensitive. Maybe we can detect mixed case and convert (for legacy naming). |
Thinking in a different direction: we could give appropriate error messages before executing the script for wrong case properties, so that they wont fail silently. |
I don't really have an opinion on which option I prefer, but everything is better than failing silently 😅 I think adding the error messages should be done in either case, but it should not be the only thing changed 🙂 |
I guess I slightly prefer my original proposal of keeping it camel-case but ignoring the case in addition to adding error messages, because I think it might be less work than switching to snake_case and it doesn't introduce a breaking change / the need for legacy support... |
There's probably no particular reason that middleware and other config options are case-sensitive.
I think it would be easier for inexperienced users, if this was made case-insensitive, as it might otherwise fail silently.
The API will still work but the otherwise correctly spelled configuration might have no effect.
The text was updated successfully, but these errors were encountered: