Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Comment preview #92

Open
rufuspollock opened this issue Apr 29, 2020 · 2 comments
Open

[Feature Request] Comment preview #92

rufuspollock opened this issue Apr 29, 2020 · 2 comments
Assignees
Labels
feature Feature request

Comments

@rufuspollock
Copy link

What problem does the feature solve?

Previewing my comment before rendering. Job story: When creating my comment and using markdown I want to preview the result so that I have confidence it looks correct before submitting (esp as i don't know whether i can edit afterwards).

Both gittalk and gitment support previewing the comment. e.g. this is gitment

image

Proposed solution

Like gitment or gittalk. I can imagine one issue is that you support multiple backends and that may cause issues re previewing in that they may operate a bit differently. I have not yet looked deeply at the code so I don't have exact ideas how to implement or how gitment does it

image

@meteorlxy
Copy link
Owner

meteorlxy commented May 6, 2020

Some platforms provide api for rendering markdown content. We can enable this feature for those platforms, so we don't have to import markdown renderer ourselves.

This feature has already been proposed in #80 , which is marked as stale yesterday. So I'll keep this issue open until it is supported

@meteorlxy meteorlxy added the feature Feature request label May 6, 2020
@meteorlxy meteorlxy changed the title [Feature Request] [Feature Request] Comment preview May 6, 2020
@meteorlxy meteorlxy self-assigned this May 6, 2020
@DynamicLoader
Copy link

Maybe we can use a javascript Marked.js to do it.In that case,we won't need to consider what backend is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants