Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 0.3.2 feature cleanup is a breaking change #1159

Open
ellttBen opened this issue Sep 15, 2023 · 1 comment
Open

[Bug]: 0.3.2 feature cleanup is a breaking change #1159

ellttBen opened this issue Sep 15, 2023 · 1 comment
Labels

Comments

@ellttBen
Copy link

ellttBen commented Sep 15, 2023

Which package is this bug report for?

mpl_utils

Which Type of Package is this bug report for?

Rust library

Issue description

The f957f2d commit , which was deployed with mpl_utils 0.3.2 , introduces a breaking change because the token feature is no longer activated by default.
This breaks using mpl_token_metadata as a dependency, and requires manually reverting mpl_utils to 0.3.1 to compile:
mpl_token_metadata depends on mpl_utils without specifying the token feature, but uses it here.

My personal recommendation is to publish a 0.3.3 version with the token feature still as default, and postpone clearing this default until a 0.4.x.

Relevant log output

No response

Priority this issue should have

High (immediate attention needed)

@ellttBen ellttBen added the bug label Sep 15, 2023
@acheroncrypto
Copy link

My personal recommendation is to publish a 0.3.3 version with the token feature still as default, and postpone clearing this default until a 0.4.x.

+1. Making changes to how features work is almost always a breaking change, therefore they should be versioned as a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants