Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: more declarative/condensed sort options #101

Open
webketje opened this issue Feb 6, 2022 · 0 comments
Open

Proposal: more declarative/condensed sort options #101

webketje opened this issue Feb 6, 2022 · 0 comments

Comments

@webketje
Copy link
Member

webketje commented Feb 6, 2022

The combined sort options aren't that semantically meaningful. Furthermore, it doesn't make that much sense to use some of them together (custom sortBy function with the others)

To do:

  • add @deprecated to the reverse,sortBy, and sortOrder options
  • adapt Readme examples
  • adapt tests
  • implement sort with type signature:
    /** @param {String|Function} sort */
    where sort:'key' or sort:'key:order' or sort: Function, where order is one of'asc'|'desc' (which map to reverse: false|true)
@webketje webketje changed the title Proposal: Deprecate "reverse: true/ false" in favor of "sortOrder: asc/desc" Proposal: more declarative/condensed sort options Feb 6, 2022
webketje added a commit that referenced this issue Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant