Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overall portability with compiler, OS and architecture detection (C/C++) #385

Open
viferga opened this issue Feb 15, 2023 · 1 comment
Labels
c/c++ Pull requests that update C/C++ code devops Related to DevOps infrastructure of the Core enhancement New feature or request

Comments

@viferga
Copy link
Member

viferga commented Feb 15, 2023

馃殌 Feature

Respect to portability, we should improve it as much as possible. For doing this there's different options but the most common one is directly supporting it from code (a part from all CMake checks that already exists and we should keep improving). All the checks in C/C++ code for portability issues have been completely hardcoded and repeated, so those should be generalized as much as possible.

For doing this, I am quoting myself from another issue:

For implementing the portability module, you can find some bases here:

predef - An excellent library for compiler, platform or architecture detection: https://sourceforge.net/projects/predef/
Argentum Online C - A game engine I wrote time ago which includes a portability module we can reuse: https://bitbucket.org/parrastudios/argentum-online-c/src/master/common/src/Portability/

Here's the issue quoted: #241

We need to standardize the import module, I copied the automatically generated _feature.h module for reference too: https://github.com/metacall/core/blob/develop/source/portability/include/portability/portability_compiler_detection.h

@viferga viferga added enhancement New feature or request c/c++ Pull requests that update C/C++ code devops Related to DevOps infrastructure of the Core labels Feb 15, 2023
@zeus2611
Copy link

zeus2611 commented Mar 5, 2023

Hey @viferga i would like to work on this issue. Is there any starting points that u can give me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/c++ Pull requests that update C/C++ code devops Related to DevOps infrastructure of the Core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants