Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap color scheme names to be theme-agnostic in embedding SDK #42680

Closed
Tracked by #42694
heypoom opened this issue May 15, 2024 · 0 comments
Closed
Tracked by #42694

Remap color scheme names to be theme-agnostic in embedding SDK #42680

heypoom opened this issue May 15, 2024 · 0 comments
Assignees

Comments

@heypoom
Copy link
Contributor

heypoom commented May 15, 2024

Currently we expose the exact colors we are using in the codebase to the SDK: brand, text-dark, text-light and text-medium. The text-* colors currently represent the different tints, where text-dark is darker than text-light.

This is problematic for dark-themed SDK users, as for dark themes those names could have the opposite semantic. We could remap these colors in the publicly-exposed theme configuration so that they're theme agnostic - so they have good meaning in both dark and light themes.

  • text-dark to text-primary
  • text-medium to text-secondary
  • text-light to text-tertiary
@heypoom heypoom changed the title Rename color scheme names to be theme-agnostic in embedding SDK Remap color scheme names to be theme-agnostic in embedding SDK May 16, 2024
@deniskaber deniskaber self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants