Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure font family are applied to all visualizations using echarts in SDK #42676

Closed
1 task done
Tracked by #42694
heypoom opened this issue May 15, 2024 · 1 comment
Closed
1 task done
Tracked by #42694
Assignees

Comments

@heypoom
Copy link
Contributor

heypoom commented May 15, 2024

We should double-check that echarts-based visualizations in embedding SDK are applying font family settings correctly.

Blockers

Cases to check

  • Metabase font families. Set theme.fontFamily to one of our supported fonts (e.g. Inter)
  • Custom font family. Set theme.fontFamily in the SDK to `"Custom". Upload a custom font in the admin settings, and apply the custom font.

Visualizations to check

  • Cartesian Charts
    • Line Chart
    • Area Chart
    • Bar Chart
    • Funnel
    • Waterfall Chart
    • Scatter Plot
  • Combo Charts

Example elements to check

  • Axis Labels
  • Axis Values
  • Values on Data Points (value above or within each bars in bar charts)
  • Goal Line Label

Out of scope visualizations (not echarts)

  • Pie Chart (using D3.js)
@heypoom
Copy link
Contributor Author

heypoom commented May 21, 2024

@albertoperdomo @NevRA Here are the test results. I think font family is applied to all vis already including Visx and D3 ones, so we are good to close this.

✅ Cartesian Charts: Line, Area and Bar charts

CleanShot 2567-05-21 at 18 38 27@2x

✅ Row Chart

CleanShot 2567-05-21 at 18 48 19@2x

✅ Pie Chart

CleanShot 2567-05-21 at 18 42 16@2x

✅ Scalar & Smart Scalar

CleanShot 2567-05-21 at 18 45 30@2x

✅ Funnel

CleanShot 2567-05-21 at 18 46 18@2x

✅ Waterfall

CleanShot 2567-05-21 at 18 47 17@2x

⛔ Pivot table does not render at all, cannot test. Will have to fix that.

@heypoom heypoom closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants