Fix metadata loading issues after tabs #42655
Merged
+151
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
commented
May 14, 2024
| @@ -126,10 +127,11 @@ export const fetchDashboard = createAsyncThunk( | |||
| fetchDashboardCancellation = null; | |||
|
|
|||
| if (dashboardType === "normal" || dashboardType === "transient") { | |||
| const selectedTabId = getSelectedTabId(getState()); | |||
| const selectedTabId = | |||
| getSelectedTabId(getState()) ?? getInitialSelectedTabId(result); | |||
There was a problem hiding this comment.
This is to make sure the initial performance fix still works. getSelectedTabId works when the dashboard was previously opened, otherwise we use getInitialSelectedTabId
ranquild
added
the
backport
|
alxnddr
approved these changes
May 14, 2024
|
@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
ranquild
added a commit
that referenced
this pull request
May 14, 2024
ranquild
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #31578
The issue was that previously we used to load all metadata upfront before showing dashcards on the screen. With the PR above we no longer do that and instead show dashcards immediately; each dashcard is responsible for loading metadata. The problem is that this causes severe performance issues with MBQL lib as metadata keeps constantly changing for queries on the screen, leading to 15s+ UI thread locks.
How to verify:
https://metaboat.slack.com/archives/C505ZNNH4/p1715690842065689