Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings encryption of analytics-uuid and anon-tracking-enabled #42651

Closed
dpsutton opened this issue May 14, 2024 · 2 comments · Fixed by #43085
Closed

Remove settings encryption of analytics-uuid and anon-tracking-enabled #42651

dpsutton opened this issue May 14, 2024 · 2 comments · Fixed by #43085
Assignees
Labels
Administration/Settings Priority:P2 Average run of the mill bug .Team/AdminWebapp Admin and Webapp team

Comments

@dpsutton
Copy link
Contributor

We encrypt some settings settings and not others when encryption is enabled.

Ex:

select * 
from setting 
where key in ('show-homepage-data', 'persisted-model-refresh-cron-schedule')
image

We should not encrypt analytics-uuid and anon-tracking-enabled.

Marked as P2 but perhaps is a P1 and we want to do this with some speed.

@dpsutton dpsutton added Priority:P2 Average run of the mill bug Administration/Settings .Team/AdminWebapp Admin and Webapp team labels May 14, 2024
@dpsutton
Copy link
Contributor Author

Question from slack:

When we get this in, will this make the analytics-uuid unencrypted as soon as someone migrates to the new version then? Or will it stay encrypted for migrating old instances and only entirely new ones will have it unencrypted?

@trinya
Copy link

trinya commented May 20, 2024

Can we up the priority for this one a bit? We need this to build the report of feature usage by customer, that would help us understand e.g. bumps in contraction and make decisions about pricing / plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Settings Priority:P2 Average run of the mill bug .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants