Scroll to created column when extracting or combining columns in chill mode #42650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romeovs
added
no-backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 44cb385...ffba4e0.
|
|
romeovs
changed the title
ranquild
reviewed
May 16, 2024
There was a problem hiding this comment.
@romeovs I think we need to toggle the flag off to not scroll on new columns added by other methods (e.g. showing the column that was previously hidden). Could you toggle the flag after scrolling? Maybe in componentDidUpdate or something like that
romeovs
force-pushed
the
scroll-to-last-column
branch
from
dd1dd87
to
4e6336e
Compare
|
@ranquild please have another look. |
ranquild
approved these changes
May 17, 2024
romeovs
added
backport
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
…l mode (#42650) * Set scrollToLastColumn ui control from column extract action * Scroll to last column when the uiControl is set * Scroll to last column when combining a column * Scroll to last column when combining a column via the + shortcut * Scroll to last column when extracting a column via the + shortcut * Remove all references to settingsSyncOptions * Check that the column is added at the end * Disable scrollToLastColumn once used * Add test that verifies scrollToLastColumn ui control has been reset
|
@romeovs this was the first commit after the v50 release branch was cut, so if you mean to backport to 49, you'll have to do that using this command: https://www.notion.so/metabase/Branching-Strategy-and-Backports-6eb577d5f61142aa960a626d6bbdfeb3?pvs=4#29927310b3b444efbb39edff6d62c549 |
metabase-bot bot
added a commit
that referenced
this pull request
May 17, 2024
…l mode (#42650) (#42832) * Set scrollToLastColumn ui control from column extract action * Scroll to last column when the uiControl is set * Scroll to last column when combining a column * Scroll to last column when combining a column via the + shortcut * Scroll to last column when extracting a column via the + shortcut * Remove all references to settingsSyncOptions * Check that the column is added at the end * Disable scrollToLastColumn once used * Add test that verifies scrollToLastColumn ui control has been reset Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>
oisincoveney
pushed a commit
that referenced
this pull request
May 20, 2024
…l mode (#42650) * Set scrollToLastColumn ui control from column extract action * Scroll to last column when the uiControl is set * Scroll to last column when combining a column * Scroll to last column when combining a column via the + shortcut * Scroll to last column when extracting a column via the + shortcut * Remove all references to settingsSyncOptions * Check that the column is added at the end * Disable scrollToLastColumn once used * Add test that verifies scrollToLastColumn ui control has been reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42674
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
a. Click the Email column header -> Click
Extract domain, host->Hostb. Click the Email column header -> Click
Combine column->Donec. Click the
Add columnbutton in the table header ->Extract part of this column->Email->Hostd. Click the
Add columnbutton in the table header ->Combine columns-> select some columns ->Done