Require an explicit knob to allow uploading ReplayIO recordings #42649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjaglumac
added
.CI & Tests
no-backport
iethree
approved these changes
May 14, 2024
|
@iethree something weird is happening now. As far as I can tell, the browser is installed But then Cypress fails due to the "invalid browser" For some reason, it doesn't see it anymore. |
nemanjaglumac
force-pushed
the
e2e-stress-test-replay-key
branch
from
2ab68ce
to
8da958e
Compare
nemanjaglumac
force-pushed
the
e2e-stress-test-replay-key
branch
from
8da958e
to
1a81844
Compare
Even though we're not using it in this workflow. 🤷
Andarist
reviewed
May 15, 2024
e2e/support/config.js
Outdated
| @@ -22,6 +22,7 @@ const sourceVersion = process.env["CROSS_VERSION_SOURCE"]; | |||
| const targetVersion = process.env["CROSS_VERSION_TARGET"]; | |||
|
|
|||
| const runWithReplay = process.env["CYPRESS_REPLAYIO_ENABLED"]; | |||
| const uploadReplayRecordings = process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"]; | |||
There was a problem hiding this comment.
I would suggest removing CYPRESS_REPLAYIO_ENABLE_UPLOAD: 0 from the other file and combining it with this change:
Suggested change
| const uploadReplayRecordings = process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"]; | |
| const uploadReplayRecordings = !!process.env["CYPRESS_REPLAYIO_ENABLE_UPLOAD"]; |
nemanjaglumac
force-pushed
the
e2e-stress-test-replay-key
branch
from
42c17e7
to
0109c60
Compare
nemanjaglumac
force-pushed
the
e2e-stress-test-replay-key
branch
from
0109c60
to
4199789
Compare
nemanjaglumac
changed the title
nemanjaglumac
commented
May 15, 2024
| @@ -47,9 +47,6 @@ jobs: | |||
| QA_DB_ENABLED: true | |||
| CYPRESS_QA_DB_MONGO: true | |||
| CYPRESS_REPLAYIO_ENABLED: 1 | |||
| CYPRESS_REPLAYIO_ENABLE_UPLOAD: 0 | |||
There was a problem hiding this comment.
This doesn't work.
false doesn't work either.
The only solution was to omit it.
uladzimirdev
approved these changes
May 15, 2024
|
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the Replay's Cypress plugin in #42507
They introduced a breaking change that I didn't know about - the runner will now throw if the API key is missing but the
runWithReplayis true in the Cypress config.The solution is to explicitly set the
uploadto true or false, depending on the context.We're now instructing the main E2E workflow to upload recordings, and we're omitting this env var from the stress-test workflow.
Slack context
Test
Successful run using the latest commit:
https://github.com/metabase/metabase/actions/runs/9095182474/job/24997844000