Add recents to Browse models table #42138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iethree
reviewed
May 2, 2024
frontend/src/metabase/browse/components/RecentlyViewedModels.tsx
Outdated
Show resolved
Hide resolved
rafpaf
force-pushed
the
browse/recents
branch
2 times, most recently
from
75c6cd6
to
5256581
Compare
* modal built * code cleanup, removing unused components * whitespace shame * adjusting unit test * removing px shame
* refactor scatter plot model to separate function * (2/3) refactor scatter plot option to separate function (#43033) * use getScatterPlotOption * use buildEChartsScatterSeries directly * remove hoveredSeriesDataKey from scatter * (3/3) improve chart model types (#43034) * create WaterfallChartModel type * create ScatterPlotModel type * rename BaseCartesianChartModel to CartesianChartModel * simplify chartModel creation in hook
* Stop returning archived metrics in available metrics * Add archived metric test * Migrate legacy metric tests * Delete lib/legacy_metric.cljc
* [Metrics V2] Port Legacy metric tests and fixes Fixes #43093 * Address pr review
* Make accordion list item content 100% wide * Remove unused Dot component * Move bucket popover trigger to the end of the item * Revert QueryColumnPicker styles to what they were before adding the info icons * Fix the height of the bucket picker
* Limit the height of the breakout popover * Allow the click action popover to untether to prevent overflowing the screen * Add reproduction for #43075 * Rename breaktrhough to breakout Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Use findAllByTestId Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Remove copy pasted question name Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Remove unused api intercept Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
…42888) * minimal support for multiple origins in security middleware * if -> when to be more idiomatic * adds tests for parse-url * if -> when * add missing new line in tests * split the logic of validation in functions * adds tests for the small functions * use namespace in tests instead of :refer
…g down to from the very top (#43114) * Avoid unnecessary re-renderings in dashboard - getEmbeddedParameterVisibility * Avoid unnecessary re-renderings in dashboard - favicon, page title * Exclude isLoadingComplete from passing down * Avoid unnecessary re-renderings in dashboard - metadata * Drop metadata from Public Dashboard * Avoid unnecessary re-renderings in dashboard - dashcardData
…43122) * Limit options on OSS Admin/Performance page * simplify * simplify * simplify * divide constants to avoid circular imports * divide constants to avoid circular imports * divide constants to avoid circular imports * simplify * simplify * simp * fix * simplify * simplify * fix test
* Convert DashboardControls to TS hooks * fix types * Modify dashboard url params to ensure that we keep hash options that haven't changed * Fix PublicDashboard and DashboardTabs tests * Use synced dashboard tabs for automatic dashboard, and use normal tabs for those with DashboardControls * reduce hash option location changes to only the ones we can change through the UI * Add comment on state management * Remove console * Attempt to solve more tests * Remove loadDashboardParams as a passed prop * Fix some tests, but will cause unit test to break * Change names to reflect actual usage * Fix lint and type issues * Add simpler url param control, simplify types, and simplify fullscreen hook * Add two way binding with url params to attempt to fix tests * Fix unit test + types * Move folders and fix imports * Use Record<string, unknown> for refresh hook * Remove console.log * Clear query parameters when ParametersList unmounts * Add comment * Revert DisplayTheme changes * Fix weird reloading problem * Fix reducers test * add code comments on selecting the tab once tab data is loaded * add code comments on unsyncing parameters * Fix e2e tests, move url reset to tabs context * Fix e2e tests * Hotfix --------- Co-authored-by: Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by: Phoomparin Mano <poom@metabase.com> Co-authored-by: Denis Berezin <denis.berezin@metabase.com>
* hide creation buttons on search and recents tabs * update e2e tests
* add media query to search button * useSmallScreen hook
… with the query (#43101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a table of recently viewed models to the Browse models table
Currently only 5 models are shown, but this will change once the relevant endpoint changes (this work is currently ongoing).
Note that the Recents table and the table below it use different loading wrappers.
Closes #42632