[Epic] Metrics v2

[kamilmielnik]

Links

• product docs:
  • ⭐ Create the new Metric entity
  • ⛓️ Sequence plan for metrics v2
  • Metrics v2 technical design docs
  • Provide an upgrade path for organic metric definitions
  • Deprecate Metrics 1.0
• Figma
  • Make Metrics in collections shine
• feature branch: metrics-v2 (integration PR: Create the new Metric entity (Metrics v2) #38457)

Implementation Plan

1. Creating new metrics

Tasks

Beta Give feedback

1. Update canSave to allow breakouts #41017
   +0
   
2. Update /api/card to allow breakouts #41016
   +0
   

2. Ad-hoc questions based on metrics

Tasks

Beta Give feedback

1. displayInfo throws on queries using metrics #41626
   .Team/QueryProcessor Priority:P2 Type:Bug +3
2. queryFromTableOrCardMetadata - make sure it uses existing metric clauses for the metric expression, copy breakout clauses from the metric #41015
   +0
   
3. displayInfo changes - double check they’re in #41014
   +0
   
4. visibleColumns - double check they’re in #41013
   +0
   
5. Use existing metric clauses for new metrics, differentiate based on data source #41011
   +0
   
6. Ignore breakouts for source-table which is a metric #41012
   +0
   
7. Handle joining tables in consuming query #41200
   +0
   

3. New questions based on Metrics

Tasks

Beta Give feedback

1. Handle loading metadata of table underlying the metric when it's used as a data source #41520
   .Frontend .Team/QueryingComponents +2
   
2. dependent-metadata does not return the table underlying the metric #41628
   .Team/QueryProcessor Priority:P2 Type:Bug +3
3. Add metrics to DataStep in the notebook editor #41184
   .Frontend .Team/QueryingComponents +2
   
4. /api/search - return new metrics for metric #41009
   +0
   
5. /api/collection/:id/items and root - return new metrics for metric #41010
   +0
   
6. Indicate whether dependent-metadata needs to be called again #41568
   .Backend .Team/QueryProcessor +2
   

4. Allow joins on Metrics

Tasks

Beta Give feedback

1. QP changes to allow for joins #41899
   +0
   
2. Support creating questions with joined metrics #41709
   +0
   
3. Fix QP to allow step previews in query builder #41917
   .Team/QueryProcessor +1
   

5. Blocks merging

Tasks

Beta Give feedback

1. [BE] [QP] [Bug] Incorrect metadata for a native model column overriden to a FK #42130
   +0
   
2. [BE] [QP] Allow using compatible metrics for the source table #42462
   2 of 2
   +0
   
3. [BE] [MBQL lib] Allow using compatible metrics for the source table #42470
   +0
   
4. [FE] [Bug] Properly pass compatible metrics to MBQL lib #42742
   +0
   
5. [FE] [Bug] Cannot replace a card with a metric on a dashboard #42598
   +0
   
6. [FE] E2E tests for metrics #42278
   +0
   
7. [FE] [Bug] Cannot use "underlying records" drill for metrics on a dashboard #42656
   +0
   
8. [FE] Disallow joining metrics #42463
   +0
   
9. [FE] Add metric icons to data and join steps #42356
   +0
   
10. [FE] Clicking "Add aggregation" button should open the expression editor if all source metrics are present in the aggregation clause #42176
    +0
    
11. [FE + BE] Do not show aggregation operators for the first stage of metrics-only queries #42168
    +0
    
12. [FE] Change the order of aggregatable options (move basic metrics to the bottom, collapse it and move up common metrics, expand it) #41935
    +0
    
13. [FE] dependentMetadata changes #42060
    +0
    
14. [FE] UI changes to the QB for new metric #41927
    +0
    
15. [FE] [Bug] cannot turn off metric visualization in collections #42618
    +0
    
16. [FE] Clearly define the constraints in metric aggregations and the user feedback when you can't save #41933
    +0
    
17. [FE] Rename "edit query definition" to "edit metric definition" #41936
    +0
    
18. [FE] The icon for a metric is incorrect in search results #41934
    +0
    
19. [FE] Metric not appearing in collections #41744
    +0
    
20. [FE] Collection not showing in search result #41743
    +0
    
21. [FE] Use default display for metrics #42028
    +0
    
22. [FE] Preview of metric should show only 10 rows #41937
    +0
    
23. [BE] [MBQL lib] Disallow joining metrics, cleanup #42471
    +0
    
24. [BE] Add newly joined metrics in the aggregation clause #41932
    +0
    
25. [BE] Make sure that model: metric is used in all BE endpoints #41993
    +0
    
26. [BE] Suggest a join condition based on the first breakout clause of joined metrics #42155
    +0
    
27. [BE] QP: column corresponding a metric aggregation should have the name of the metric #42001
    +0
    
28. [BE] dependentMetadata changes #42056
    +0
    
29. [BE] Renaming a metric does not work #41929
    +0
    
30. [BE] The run button (play icon) should only be enabled when the save button gets enabled #41928
    +0
    
31. [BE] Metrics do not appear in recently viewed #41930
    +0
    

6. Blocks merging - migration

• product doc: Deprecate Metrics 1.0
• tech doc: Metrics v2 migration

Tasks

Beta Give feedback

1. FE - Remove metrics v1 UI #37982
   .Frontend .Team/QueryingComponents Administration/Metrics & Segments +3
   
2. Create test harness based on cloud customer metric usage #42186
   +0
   
3. Create new collection for v2 metrics #42187
   +0
   
4. Implement metric migration #42188
   +0
   
5. Implement question migration for single metric #42189
   +0
   
6. Implement question migration for multiple metrics #42190
   +0
   
7. Implement downgrade (restoring the original questions) #42191
   +0
   

7. Does not block merging

Tasks

Beta Give feedback

1. [BE] Add type property to /api/table/card__:id/query_metadata to avoid unneeded requests to /api/card/:id #43151
   .Backend +1
   
2. [BE] [QP] Legacy metric cleanup #42464
   2 of 2
   +0
   
3. [BE] [Bug] query_metadata returns archived metrics #42893
   +0
   
4. [BE] Stage one should show the name of the metric and not the name of the underlying table in joins #41931
   +0
   
5. [BE] [QP] [Bug] Wrong column names for columns for metric aggregation clauses #42392
   .Team/QueryProcessor Administration/Metrics & Segments Priority:P2 +3
6. [BE] Review Related metrics results #41473
   +0
7. [BE] Review Metric revisions
8. [BE] [QP] Ensure custom expressions are handled without name clashes #42782
   +0
   
9. [BE] [Bug] Cannot combine compatible timeseries metrics in dashboards #42575
   +0
   
10. [BE] [QP] Metrics aren't working for Druid (old driver) #42237
    +0
11. [BE] [QP] [Bug] Incorrect results when using custom columns in metric queries #42360
    +0
    
12. [BE] Comparing metrics is slow (joining metrics and selecting them in aggregation clause) #42252
    +0
    
13. [BE] [QP] Check which drivers lose metric support because of nested queries #42474
    +0
    
14. [BE] [Bug] Metrics are not returned by /api/activity/popular_items #42607
    +0