Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of mesos version in the build #96

Open
erikdw opened this issue Feb 22, 2016 · 1 comment
Open

improve handling of mesos version in the build #96

erikdw opened this issue Feb 22, 2016 · 1 comment

Comments

@erikdw
Copy link
Collaborator

erikdw commented Feb 22, 2016

As noted in PR #91, we have a couple of manual modifications that are necessary when changing the mesos version:

  1. pom.xml's mesos.version property needs to be updated so that the package's included mesos dependency is correct.
  2. (only applicable when using Docker image) we need to update the version of mesos in the Dockerfile.

Update pom.xml's mesos.version

We should consider some mechanism for updating the mesos.version property without resorting to something like sed. e.g., maybe one of these Maven plugins:

  • properties
  • versions
  • replacer

(DONE) Update Dockerfile's mesos version:

Ideally we would just use a vanilla ubuntu Docker image as the FROM, and then install the mesos package for the chosen mesos version. Unfortunately, the mesos packages published by Mesosphere have an unpredictable superfluous identifier in the names, which prevents simply doing something like this:

FROM ubuntu:14.04
...
RUN apt-get install -y mesos=0.26.0-0.2.145.ubuntu1404

So instead of this we can resort to using sed to update the base image in the Dockerfile, using a lookup-table from bin/build-release.sh to choose the appropriate base image for each supported mesos version.

@erikdw
Copy link
Collaborator Author

erikdw commented Apr 9, 2016

#120 aims to fix the Dockerfile portion of this issue, along with adding support for onbuild Docker images.

@erikdw erikdw added the docker label Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant