Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dumping environment variables in JobNotificationObserver #888

Open
Sytten opened this issue Nov 8, 2018 · 0 comments
Open

Avoid dumping environment variables in JobNotificationObserver #888

Sytten opened this issue Nov 8, 2018 · 0 comments

Comments

@Sytten
Copy link

Sytten commented Nov 8, 2018

While looking at our logs, I realized that we have a lot of:
JobNotificationObserver does not handle X where X is JobQueued, JobStarted or JobFinished.
I am not sure where those come from?
Nonetheless, The problem is that this logger dumps all environment variables of the job, which might contain some sensitive information (like DB passwords since chronos doesnt integrate well with vault or other similar products).
Is there a way to avoid the logger from this class from dumping them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant