Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping/css #1335

Closed
wants to merge 14 commits into from
Closed

Overlapping/css #1335

wants to merge 14 commits into from

Conversation

thisiskaransgit
Copy link
Contributor

@thisiskaransgit thisiskaransgit commented Jul 30, 2023 •
edited

Description

Notes for Reviewers

  • This PR removes unused and overlapping CSS styles to improve the performance and maintainability of the codebase.
  • Replaces Third-party stylesheets and uses our own
  • Replaces CSS files with sass files

Dividing the work into 2 parts:

  1. The first PR clears the evident, unused CSS styles from the website, by removing the third-party stylesheets and including our own
  2. Next iteration would be to clear the other residuals along with introducing our own multilevel navigation(replacing Stellarnav) and carousel for the site. Also, to review and minify the use of javascript cdns

Code coverage results (Current Condition):
Screenshot from 2023-07-31 00-27-20

Code coverage results (After):
image

  • Third-party stylesheets and JavaScript CDNs are one of the leading causes of the performance issues, as they are slowing down the page loading.

Signed commits

  • Yes, I signed my commits.

@thisiskaransgit
html updated
c31cab2 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
css styles removed
827ed80 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
overlapping styles removed
3e07f6a 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@netlify
Copy link

netlify bot commented Jul 30, 2023 •
edited

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 4c481ac
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/64e616785904a4000841c53e
😎 Deploy Preview https://deploy-preview-1335--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisiskaransgit thisiskaransgit added the pr/do-not-merge PRs not ready to be merged label Jul 30, 2023
@thisiskaransgit
update styles
c3db1e6 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
resolving styles issues
964c30e 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
feat: updated stylesheets
c1d3d96 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
Merge branch 'master' into overlapping/css
2f20a48
@thisiskaransgit thisiskaransgit marked this pull request as ready for review August 5, 2023 21:20
@thisiskaransgit
updated features.scss
5b14429 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
Merge branch 'master' into overlapping/css
bf9efb1
@thisiskaransgit thisiskaransgit removed the pr/do-not-merge PRs not ready to be merged label Aug 7, 2023
Chadha93
Chadha93 previously approved these changes Aug 15, 2023
View reviewed changes
@thisiskaransgit
update
1bad99f 
Signed-off-by: Karan Singh Thakur <karanthakur.work@gmail.com>
@thisiskaransgit
Merge branch 'master' into overlapping/css
4c481ac 
Signed-off-by: Karan Thakur <karanthakur.work@gmail.com>
@Chadha93
Copy link
Member

@vishalvivekm Will you test out this PR once since it's removing redundant CSS.

@stale
Copy link

stale bot commented Sep 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 23, 2023
@stale
Copy link

stale bot commented Sep 30, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Sep 30, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chadha93 Chadha93 Chadha93 left review comments

@Ghat0tkach Ghat0tkach Awaiting requested review from Ghat0tkach

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Assignees
No one assigned
Labels
area/website component/integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Consolidate duplicative and unused CSS
3 participants
@thisiskaransgit @Chadha93 @vishalvivekm