Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impacts are all the same! #4

Open
filipesaz opened this issue Aug 19, 2020 · 1 comment
Open

Impacts are all the same! #4

filipesaz opened this issue Aug 19, 2020 · 1 comment

Comments

@filipesaz
Copy link

Hi!

You are declaring:
let lightImpactGenerator = UIImpactFeedbackGenerator()
let heavyImpactGenerator = UIImpactFeedbackGenerator()

Where, it seems to me, you need to be declaring:
let lightImpactGenerator = UIImpactFeedbackGenerator.init(style: .light)
let heavyImpactGenerator = UIImpactFeedbackGenerator.init(style: .heavy)

Also, you're going to need to code for the fact that .rigid and .soft styles are only available in ios13+.

@mergesort
Copy link
Owner

Hey @filipesaz, I took a quick look and it seems that you're right! I haven't worked on FeedbackEffect in a while, but if you're willing to file a pull request I'd gladly code review and merge it in to make the appropriate changes. Does that sound like something you'd be interested din doing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants